Merge pull request #281218 from lf-/jade/fix-diffoscope

diffoscope: fix on aarch64-darwin
This commit is contained in:
7c6f434c 2024-01-20 15:08:57 +00:00 committed by GitHub
commit 121c2dcb97
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 2 deletions

View file

@ -36,11 +36,14 @@ stdenv.mkDerivation rec {
substituteInPlace fpcsrc/compiler/systems/t_linux.pas --subst-var-by syslibpath "${glibc}/lib"
# Replace the `codesign --remove-signature` command with a custom script, since `codesign` is not available
# in nixpkgs
# Remove the -no_uuid strip flag which does not work on llvm-strip, only
# Apple strip.
substituteInPlace fpcsrc/compiler/Makefile \
--replace \
"\$(CODESIGN) --remove-signature" \
"${./remove-signature.sh}" \
--replace "ifneq (\$(CODESIGN),)" "ifeq (\$(OS_TARGET), darwin)"
--replace "ifneq (\$(CODESIGN),)" "ifeq (\$(OS_TARGET), darwin)" \
--replace "-no_uuid" ""
'';
NIX_LDFLAGS = lib.optionalString

View file

@ -219,7 +219,7 @@ python3.pkgs.buildPythonApplication rec {
# oggvideotools is broken on Darwin, please put it back when it will be fixed?
++ lib.optionals stdenv.isLinux [ oggvideotools ]
# This doesn't work on aarch64-darwin
++ lib.optionals (stdenv.hostPlatform != "aarch64-darwin") [ gnumeric ]
++ lib.optionals (stdenv.hostPlatform.system != "aarch64-darwin") [ gnumeric ]
));
nativeCheckInputs = with python3.pkgs; [
@ -248,6 +248,15 @@ python3.pkgs.buildPythonApplication rec {
"test_non_unicode_filename"
"test_listing"
"test_symlink_root"
# Appears to be a sandbox related issue
"test_trim_stderr_in_command"
# Seems to be a bug caused by having different versions of rdata than
# expected. Will file upstream.
"test_item_rdb"
# Caused by getting an otool command instead of llvm-objdump. Could be Nix
# setup, could be upstream bug. Will file upstream.
"test_libmix_differences"
];
disabledTestPaths = [