cudaPackages.backendStdenv: use gccForLibs

instead of the unreliable libcxx hack

(cherry picked from commit dc6a8f9f7912363577e11520bafa040c0db14359)
This commit is contained in:
Rahul Butani 2023-04-12 14:51:11 -05:00 committed by Someone Serge
parent 290ea23649
commit 210ce38408
No known key found for this signature in database
GPG key ID: 7B0E3B1390D61DA4
2 changed files with 20 additions and 10 deletions

View file

@ -7,6 +7,7 @@
stdenv,
wrapCCWith,
}:
let
gccMajorVersion = nvccCompatibilities.${cudaVersion}.gccMaxMajorVersion;
# We use buildPackages (= pkgsBuildHost) because we look for a gcc that
@ -15,25 +16,35 @@ let
# The target platform of buildPackages.gcc is our host platform, so its
# .lib output should be the libstdc++ we want to be writing in the runpaths
# Cf. https://github.com/NixOS/nixpkgs/pull/225661#discussion_r1164564576
nixpkgsCompatibleLibstdcxx = buildPackages.gcc.cc.lib;
ccForLibs = stdenv.cc.cc;
cxxStdlib = lib.getLib ccForLibs;
nvccCompatibleCC = buildPackages."gcc${gccMajorVersion}".cc;
cc = wrapCCWith {
cc = nvccCompatibleCC;
# This option is for clang's libcxx, but we (ab)use it for gcc's libstdc++.
# Note that libstdc++ maintains forward-compatibility: if we load a newer
# libstdc++ into the process, we can still use libraries built against an
# older libstdc++. This, in practice, means that we should use libstdc++ from
# the same stdenv that the rest of nixpkgs uses.
# We currently do not try to support anything other than gcc and linux.
libcxx = nixpkgsCompatibleLibstdcxx;
# Note: normally the `useCcForLibs`/`gccForLibs` mechanism is used to get a
# clang based `cc` to use `libstdc++` (from gcc).
# Here we (ab)use it to use a `libstdc++` from a different `gcc` than our
# `cc`.
# Note that this does not inhibit our `cc`'s lib dir from being added to
# cflags/ldflags (see `cc_solib` in `cc-wrapper`) but this is okay: our
# `gccForLibs`'s paths should take precedence.
useCcForLibs = true;
gccForLibs = ccForLibs;
};
cudaStdenv = overrideCC stdenv cc;
passthruExtra = {
inherit nixpkgsCompatibleLibstdcxx;
nixpkgsCompatibleLibstdcxx = lib.warn "cudaPackages.backendStdenv.nixpkgsCompatibleLibstdcxx is misnamed, deprecated, and will be removed after 24.05" cxxStdlib;
# cc already exposed
};
assertCondition = true;
in
# We should use libstdc++ at least as new as nixpkgs' stdenv's one.
assert ((stdenv.cc.cxxStdlib.kind or null) == "libstdc++")
-> lib.versionAtLeast cxxStdlib.version stdenv.cc.cxxStdlib.lib.version;
lib.extendDerivation assertCondition passthruExtra cudaStdenv

View file

@ -282,7 +282,6 @@ let
# loading multiple extensions in the same python program due to duplicate protobuf DBs.
# 2) Patch python path in the compiler driver.
preBuild = lib.optionalString cudaSupport ''
export NIX_LDFLAGS+=" -L${backendStdenv.nixpkgsCompatibleLibstdcxx}/lib"
patchShebangs ../output/external/xla/third_party/gpus/crosstool/clang/bin/crosstool_wrapper_driver_is_not_gcc.tpl
'' + lib.optionalString stdenv.isDarwin ''
# Framework search paths aren't added by bintools hook