From 44c267f9542df775af23836b881ee0e6697467f4 Mon Sep 17 00:00:00 2001 From: Matt McHenry Date: Tue, 28 Sep 2021 20:25:47 -0400 Subject: [PATCH] pythonPackages.requests: fix dependencies for python2 * brotlicffi does not support python 2, so only include it as a build input of requests if requests is being built for python 3. otherwise, fall back to brotli. * requests 2.26 release notes specify that charset-normalizer is only for python 3, while chardet is only for python 2. correct build inputs to reflect this. (charset-normalizer does not build with python 2.) fixes #138584 --- pkgs/development/python-modules/requests/default.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/development/python-modules/requests/default.nix b/pkgs/development/python-modules/requests/default.nix index f7c2cdbf27ac..44c5b7331d61 100644 --- a/pkgs/development/python-modules/requests/default.nix +++ b/pkgs/development/python-modules/requests/default.nix @@ -36,10 +36,7 @@ buildPythonPackage rec { ''; propagatedBuildInputs = [ - brotlicffi certifi - charset-normalizer - chardet idna urllib3 ] ++ lib.optionals (isPy3k) [ @@ -47,6 +44,7 @@ buildPythonPackage rec { charset-normalizer ] ++ lib.optionals (isPy27) [ brotli + chardet ]; checkInputs = [