swendel/nixpkgs
1
0
Fork 0
mirror of https://github.com/SebastianWendel/nixpkgs.git synced 2024-09-20 04:19:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

kikit: 1.4.0 -> 1.5.0

Browse source 
This includes support for KiCad 8 (see complete changelog
[here](https://github.com/yaqwsx/KiKit/releases/tag/v1.5.0)), which should unblock
https://github.com/NixOS/nixpkgs/pull/291134.

With this upgrade, a test started failing:

    $ nix build .#kikit
    ...
    kikit> not ok 40 Steel stencils
    kikit> # (in test file /build/source/test/system/stencil.bats, line 6)
    kikit> #   `kikit stencil create  --jigsize 60 60 $RES/conn.kicad_pcb steelStencil' failed
    kikit> # 04:32:16: Error: Directory '/homeless-shelter' couldn't be created (error 13: Permission denied)
    kikit> # An error occurred: OpenSCAD is not available.
    kikit> # Did you install it? Program `openscad` has to be in PATH
    kikit> # No output files produced
    kikit> not ok 41 Steel stencils with cutout
    kikit> # (in test file /build/source/test/system/stencil.bats, line 10)
    kikit> #   `kikit stencil create  --jigsize 60 60 --cutout J4 $RES/conn.kicad_pcb steelStencil' failed
    kikit> # 04:32:17: Error: Directory '/homeless-shelter' couldn't be created (error 13: Permission denied)
    kikit> # An error occurred: OpenSCAD is not available.
    kikit> # Did you install it? Program `openscad` has to be in PATH
    kikit> # No output files produced
    kikit> not ok 42 Printed stencils
    kikit> # (in test file /build/source/test/system/stencil.bats, line 14)
    kikit> #   `kikit stencil createprinted \' failed
    kikit> # 04:32:17: Error: Directory '/homeless-shelter' couldn't be created (error 13: Permission denied)
    kikit> # An error occurred: OpenSCAD is not available.
    kikit> # Did you install it? Program `openscad` has to be in PATH
    kikit> # No output files produced
    kikit> make: *** [Makefile:40: test-system] Error 1
    kikit> /nix/store/3qnm3nwjajgqa771dmi2dnwxrw0kzq5m-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context
    error: builder for '/nix/store/f3klmz0qvi6yr3qfy7cww434f2z4kjx5-kikit-1.5.0.drv' failed with exit code 2;

This is failing in some pretty old kikit code, so I think this is just
failing due to kikit now having more complete code coverage. While
researching this, I discovered kikit's documentation about [optional
dependencies], which I suppose we don't have good support for right now.
Rather than invent a new option for that, I've opted to preserve the
existing behavior and just do the bare minimum to keep the build
passing.

[optional dependencies]: https://github.com/yaqwsx/KiKit/blob/v1.5.0/docs/installation/intro.md#optional-dependencies
This commit is contained in:
Jeremy Fleischman 2024-02-26 20:25:56 -08:00
parent 860a2c5921
commit 9f7c981bec
No known key found for this signature in database
GPG key ID: 19319CD8416A642B
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkgs/by-name/ki/kikit/default.nix
View file

@ -10,6 +10,7 @@
, numpy
, click
, markdown2
, openscad
, pytestCheckHook
, commentjson
, wxpython
@ -23,7 +24,7 @@ let
in
buildPythonApplication rec {
pname = "kikit";
version = "1.4.0";
version = "1.5.0";
format = "setuptools";
disabled = pythonOlder "3.7";
@ -32,7 +33,7 @@ buildPythonApplication rec {
owner = "yaqwsx";
repo = "KiKit";
rev = "refs/tags/v${version}";
hash = "sha256-88/1bL3MtawR/8P8U1jHatMbq+JxF1qb+plH3rYh1qU=";
hash = "sha256-f8FB6EEy9Ch4LcMKd9PADXV9QrSb7e22Ui86G6AnQKE=";
};
propagatedBuildInputs = [
@ -40,6 +41,9 @@ buildPythonApplication rec {
numpy
click
markdown2
# OpenSCAD is an optional dependency (see
# https://github.com/yaqwsx/KiKit/blob/v1.5.0/docs/installation/intro.md#optional-dependencies).
openscad
commentjson
# https://github.com/yaqwsx/KiKit/issues/575
wxpython