Apply suggestions from code review

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
This commit is contained in:
Alexis Hildebrandt 2023-04-16 07:27:33 +02:00 committed by GitHub
parent f92d7c3a20
commit f35c2b0b92
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 10 deletions

View file

@ -7,10 +7,6 @@
, guiSupport ? stdenv.isDarwin, pinentry
}:
let
pinentryBinaryPath = pinentry.binaryPath or "bin/pinentry";
in
assert guiSupport -> enableMinimal == false;
stdenv.mkDerivation rec {
@ -53,7 +49,7 @@ stdenv.mkDerivation rec {
"--with-ksba-prefix=${libksba.dev}"
"--with-npth-prefix=${npth}"
]
++ lib.optional guiSupport "--with-pinentry-pgm=${pinentry}/${pinentryBinaryPath}"
++ lib.optional guiSupport "--with-pinentry-pgm=${pinentry}/${pinentry.binaryPath or "bin/pinentry"}"
++ lib.optional stdenv.isDarwin "--disable-ccid-driver";
postInstall = if enableMinimal

View file

@ -8,10 +8,6 @@
, withTpm2Tss ? !stdenv.isDarwin && !enableMinimal, tpm2-tss
}:
let
pinentryBinaryPath = pinentry.binaryPath or "bin/pinentry";
in
assert guiSupport -> enableMinimal == false;
stdenv.mkDerivation rec {
@ -54,7 +50,7 @@ stdenv.mkDerivation rec {
"--with-ksba-prefix=${libksba.dev}"
"--with-npth-prefix=${npth}"
]
++ lib.optional guiSupport "--with-pinentry-pgm=${pinentry}/${pinentryBinaryPath}"
++ lib.optional guiSupport "--with-pinentry-pgm=${pinentry}/${pinentry.binaryPath or "bin/pinentry"}"
++ lib.optional withTpm2Tss "--with-tss=intel"
++ lib.optional stdenv.isDarwin "--disable-ccid-driver";