mirror of
https://github.com/SebastianWendel/nixpkgs.git
synced 2024-10-17 19:23:17 +02:00
b2eb2c8b4f
This reverts commit 988f5a5910.
The release process for many OCaml packages and in extension mirage
related packages usually entails creating a release in the respective
own repository so a release tarball becomes available and then opening a
PR against ocaml/opam-repository to finalize the release. During this
new issues can be discovered which push the release back.
This happened for mirage-tcpip 6.1.0 several times:
https://github.com/ocaml/opam-repository/pull/18357
Prompting in total 3 different 6.1.0 releases with different hashes
respectively (the hash for ocamlPackages.tcpip.src shouldn't be
reproducible anymore, but we probably have cached the tarball already).
Ultimately the PR to opam-repository was closed to investigate some
failures on opam-repository's CI and the release postponed:
https://github.com/ocaml/opam-repository/pull/18357#issuecomment-808434285
I jumped the gun with the release and updated tcpip in nixpkgs before
tcpip was “properly” released in opam. I usually watch the github
repository of package I maintain for releases and can react pretty
quickly to a release as a result. Most of the time I also check
opam-repository's PRs nowadays for extra context or information, but
when everything seems fine and tests succeed I deem the update alright
to PR to nixpkgs. Being faster than opam was achievable in these cases
and actually seems kind of tantalizing.
In the light of this experience however, we should wait for the opam
PR getting merged at least for some packages that exhibit this behavior
of rereleasing the same version number multiple times to get the release
just right (afaik the 6.1.0 tag pointed to three different revisions for
tcpip). To me this is questionable upstream behavior we just have to deal
with in some way.
71 lines
1.5 KiB
Nix
71 lines
1.5 KiB
Nix
{ lib, buildDunePackage, fetchurl
|
|
, bisect_ppx, ppx_cstruct
|
|
, rresult, cstruct, cstruct-lwt, mirage-net, mirage-clock
|
|
, mirage-random, mirage-stack, mirage-protocols, mirage-time
|
|
, ipaddr, macaddr, macaddr-cstruct, mirage-profile, fmt
|
|
, lwt, lwt-dllist, logs, duration, randomconv, ethernet
|
|
, alcotest, mirage-flow, mirage-vnetif, pcap-format
|
|
, mirage-clock-unix, arp, ipaddr-cstruct, mirage-random-test
|
|
, lru
|
|
}:
|
|
|
|
buildDunePackage rec {
|
|
pname = "tcpip";
|
|
version = "6.0.0";
|
|
|
|
useDune2 = true;
|
|
|
|
src = fetchurl {
|
|
url = "https://github.com/mirage/mirage-${pname}/releases/download/v${version}/${pname}-v${version}.tbz";
|
|
sha256 = "0wbrs8jz1vw3zdrqmqcwawxh4yhc2gy30rw7gz4w116cblkvnb8s";
|
|
};
|
|
|
|
nativeBuildInputs = [
|
|
bisect_ppx
|
|
ppx_cstruct
|
|
];
|
|
|
|
propagatedBuildInputs = [
|
|
rresult
|
|
cstruct
|
|
cstruct-lwt
|
|
mirage-net
|
|
mirage-clock
|
|
mirage-random
|
|
mirage-random-test
|
|
mirage-stack
|
|
mirage-protocols
|
|
mirage-time
|
|
ipaddr
|
|
macaddr
|
|
macaddr-cstruct
|
|
mirage-profile
|
|
fmt
|
|
lwt
|
|
lwt-dllist
|
|
logs
|
|
duration
|
|
randomconv
|
|
ethernet
|
|
lru
|
|
];
|
|
|
|
doCheck = true;
|
|
checkInputs = [
|
|
alcotest
|
|
mirage-flow
|
|
mirage-vnetif
|
|
pcap-format
|
|
mirage-clock-unix
|
|
arp
|
|
ipaddr-cstruct
|
|
];
|
|
|
|
meta = with lib; {
|
|
description = "OCaml TCP/IP networking stack, used in MirageOS";
|
|
homepage = "https://github.com/mirage/mirage-tcpip";
|
|
maintainers = [ maintainers.sternenseemann ];
|
|
license = licenses.isc;
|
|
};
|
|
}
|